Closed
Conversation
adnanhemani
requested changes
Aug 21, 2023
Member
adnanhemani
left a comment
adnanhemani
left a comment
There was a problem hiding this comment.
In most languages, testing "private" or "internal" functions is not a pattern that is encouraged (if that pattern even allows it at all). While I appreciate the additional test coverage these tests provide greatly, I think it would be best if we made test cases using Table#drop and Table#select to trigger all the conditional statements within Table#_varargs_labels_as_list instead. Let me know your thoughts.
Member
|
Closing PR as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Wrote test for _varargs_labels_as_list
Changes proposed:
tests for _varargs_labels_as_list